Don't code sign for iOS simulator SDK builds #903
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. I've made a small change to the project settings to not code sign the iOS framework target when built against the simulator SDK. The reason for this is because when built with carthage on a CI server with no code signing identities, it defaults to building with the simulator SDK which doesn't require code signing like the iphoneos SDK does. Other frameworks supporting Carthage installs have been doing this as well it seems (example: ReactiveCocoa/ReactiveCocoa@f685971)